Re: [PATCH v3] ACPI: resource: Remove "Zen" specific match and quirks

[Limonciello, Mario]

On 6/3/2023 5:19 AM, Chuanhong Guo wrote:
> Hi!
>
> On Fri, Jun 2, 2023 at 6:12 AM Mario Limonciello
> <mario.limonciello@xxxxxxx> wrote:
> > commit 9946e39fe8d0 ("ACPI: resource: skip IRQ override on
> > AMD Zen platforms") attempted to overhaul the override logic so it
> > didn't apply on X86 AMD Zen systems.  This was intentional so that
> > systems would prefer DSDT values instead of default MADT value for
> > IRQ 1 on Ryzen 6000 systems which typically uses ActiveLow for IRQ1.
> >
> > This turned out to be a bad assumption because several vendors
> > add Interrupt Source Override but don't fix the DSDT. A pile of
> > quirks was collecting that proved this wasn't sustaintable.
> >
> > Furthermore some vendors have used ActiveHigh for IRQ1.
> > To solve this problem revert the following commits:
> > * commit 17bb7046e7ce ("ACPI: resource: Do IRQ override on all TongFang
> > GMxRGxx")
> > * commit f3cb9b740869 ("ACPI: resource: do IRQ override on Lenovo 14ALC7")
> > * commit bfcdf58380b1 ("ACPI: resource: do IRQ override on LENOVO IdeaPad")
> > * commit 7592b79ba4a9 ("ACPI: resource: do IRQ override on XMG Core 15")
> > * commit 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen
> > platforms")
> >
> > Cc: ofenfisch@xxxxxxxxxxxxxx
> > Cc: wse@xxxxxxxxxxxxxxxxxxx
> > Cc: adam.niederer@xxxxxxxxx
> > Cc: adrian@xxxxxxxxx
> > Cc: jirislaby@xxxxxxxxxx
> > Cc: Renjith.Pananchikkal@xxxxxxx
> > Cc: anson.tsao@xxxxxxx
> > Cc: Richard.Gong@xxxxxxx
> > Cc: Chuanhong Guo <gch981213@xxxxxxxxx>
> > Reported-by: evilsnoo@xxxxxxxxx
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217394
> > Reported-by: ruinairas1992@xxxxxxxxx
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217406
> > Reported-by: nmschulte@xxxxxxxxx
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217336
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> > ---
> > v2->v3:
> >   * Adjust to drop heuristics entirely
> >   * Drop tested tags
> >   * Add more links and people to Cc
> >   * Drop Fixes tag as this got a lot more risky
> > v1->v2:
> >   * Rebase on 71a485624c4c ("ACPI: resource: Add IRQ override quirk for LG UltraPC 17U70P")
> >   * Pick up tag
> >
> > Rafael,
> > Please hold off on picking this up until the majority of those on CC
> > have tested it on hardware they have and reported results.
> >
> > Everyone else,
> > Please test. If you have problems with this applied, please share
> > an acpidump and dmesg either on a bug or to me privately.
> I was expecting this patch to break my keyboard again but
> that didn't happen. I'm on the latest UEFI from Lenovo.
> By dumping ACPI APIC I found that there's this:
>
> [0C4h 0196   1]                Subtable Type : 02 [Interrupt Source Override]
> [0C5h 0197   1]                       Length : 0A
> [0C6h 0198   1]                          Bus : 00
> [0C7h 0199   1]                       Source : 01
> [0C8h 0200   4]                    Interrupt : 00000001
> [0CCh 0204   2]        Flags (decoded below) : 0007
>                                      Polarity : 3
>                                  Trigger Mode : 1
>
> I don't have a dump of the ACPI table from older UEFIs anymore.
>
> Tested on Lenovo Thinkbook 14G4+ ARA with the latest
> UEFI (J6CN45WW).
>
> Tested-by: Chuanhong Guo <gch981213@xxxxxxxxx>
Thanks!  Yours is the one I was most worried about.