Re: [PATCH] evm: Complete description of evm_inode_setattr()

From: Mimi Zohar
Date: Mon Jun 05 2023 - 09:13:26 EST


On Mon, 2023-06-05 at 13:57 +0200, Roberto Sassu wrote:
> On Mon, 2023-03-06 at 11:40 +0100, Roberto Sassu wrote:
> > From: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
> >
> > Add the description for missing parameters of evm_inode_setattr() to
> > avoid the warning arising with W=n compile option.
> >
> > Fixes: 817b54aa45db ("evm: add evm_inode_setattr to prevent updating an invalid security.evm")
> > Fixes: c1632a0f1120 ("fs: port ->setattr() to pass mnt_idmap")
> > Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
>
> Hi Mimi
>
> this probably got lost. It was also reviewed by Stefan:
>
> Reviewed-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
>
> Could you please take it?

Thanks for the reminder. In case kernel-doc changes are backported to
stable, I've added # v3.2+ and # v6.3+ respectively to the Fixes lines.

There are two other warnings in EVM. Any chance you're planning on
fixing them as well?

--
thanks,

Mimi