Re: [PATCH v5] hv_netvsc: Allocate rx indirection table size dynamically

From: kernel test robot
Date: Mon Jun 05 2023 - 05:17:18 EST


Hi Shradha,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on horms-ipvs/master v6.4-rc5 next-20230605]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Shradha-Gupta/hv_netvsc-Allocate-rx-indirection-table-size-dynamically/20230605-151438
base: linus/master
patch link: https://lore.kernel.org/r/1685949196-16175-1-git-send-email-shradhagupta%40linux.microsoft.com
patch subject: [PATCH v5] hv_netvsc: Allocate rx indirection table size dynamically
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20230605/202306051754.7zMgBFMX-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/cd4dda15951edad50a4ffd51e084863ef2f50bd3
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Shradha-Gupta/hv_netvsc-Allocate-rx-indirection-table-size-dynamically/20230605-151438
git checkout cd4dda15951edad50a4ffd51e084863ef2f50bd3
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/hyperv/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306051754.7zMgBFMX-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/net/hyperv/rndis_filter.c: In function 'rndis_filter_device_remove':
drivers/net/hyperv/rndis_filter.c:1612:54: error: 'net' undeclared (first use in this function)
1612 | struct net_device_context *ndc = netdev_priv(net);
| ^~~
drivers/net/hyperv/rndis_filter.c:1612:54: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/hyperv/rndis_filter.c:1613:28: warning: unused variable 'net' [-Wunused-variable]
1613 | struct net_device *net = hv_get_drvdata(dev);
| ^~~


vim +/net +1613 drivers/net/hyperv/rndis_filter.c

1607
1608 void rndis_filter_device_remove(struct hv_device *dev,
1609 struct netvsc_device *net_dev)
1610 {
1611 struct rndis_device *rndis_dev = net_dev->extension;
1612 struct net_device_context *ndc = netdev_priv(net);
> 1613 struct net_device *net = hv_get_drvdata(dev);
1614
1615 /* Halt and release the rndis device */
1616 rndis_filter_halt_device(net_dev, rndis_dev);
1617
1618 netvsc_device_remove(dev);
1619
1620 ndc->rx_table_sz = 0;
1621 kfree(ndc->rx_table);
1622 ndc->rx_table = NULL;
1623 }
1624

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki