Re: [PATCH v3] gpio: sifive: Add missing check for platform_get_irq

[Andy Shevchenko]

On Mon, Jun 5, 2023 at 12:13 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Mon, Jun 5, 2023 at 4:49 AM Jiasheng Jiang <jiasheng@xxxxxxxxxxx> wrote:
> >
> > Add the missing check for platform_get_irq() and return error code
> > if it fails.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Actually, the change is functional and now the wrong IRQ numbering in
the DT will fail the ->probe(). This needs an additional explanation
in the commit message why it's not a problem.

> > -       for (i = 0; i < ngpio; i++)
> > -               chip->irq_number[i] = platform_get_irq(pdev, i);
> > +       for (i = 0; i < ngpio; i++) {
> > +               ret = platform_get_irq(pdev, i);
> > +               if (ret < 0)
> > +                       return ret;
> > +               chip->irq_number[i] = ret;
> > +       }

-- 
With Best Regards,
Andy Shevchenko