Re: [patch 5/6] x86/smp: Split sending INIT IPI out into a helper function

From: Thomas Gleixner
Date: Mon Jun 05 2023 - 03:55:34 EST


On Sun, Jun 04 2023 at 07:02, Mika Penttilä wrote:
> On 3.6.2023 23.07, Thomas Gleixner wrote:
>> +/*
>> + * Wake up AP by INIT, INIT, STARTUP sequence.
>> + */
>> +static int wakeup_secondary_cpu_via_init(int phys_apicid, unsigned long start_eip)
>> +{
>> + unsigned long send_status = 0, accept_status = 0;
>> + int maxlvt, num_starts, j;
>> +
>> + preempt_disable();
>
> This seems like an unbalanced preempt disable..

Right. I screwed up a rebase completely....