Re: [PATCH RFC 1/7] dt-bindings: connector: usb-connector: add a gpio used to determine the Type-C port plug orientation

[Neil Armstrong]

On 03/06/2023 22:22, Dmitry Baryshkov wrote:
> On 01/06/2023 17:07, Neil Armstrong wrote:
> > On some platforms, the Type-C plug orientation is given on a GPIO line.
> >
> > Document this optional Type-C connector property, and take the
> > assumption an active level represents an inverted/flipped orientation.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/connector/usb-connector.yaml | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > index ae515651fc6b..c3884eed6ba4 100644
> > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > @@ -114,6 +114,11 @@ properties:
> >       description: Set this property if the Type-C connector has no power delivery support.
> >       type: boolean
> > +  orientation-gpios:
> > +    description: An input gpio for Type-C connector orientation, used to detect orientation
> > +      of the Type-C connector. GPIO active level means "CC2" or Reversed/Flipped orientation.
> > +    maxItems: 1
>
> Should this be a property of the connector or of the parent device node? I mean, unlike usb-b-connector (where ID and Vbus can be simple GPIOs nearly directly connected to the pins of the connector) for the USB-C the orientation is not a connector's GPIO, but rather some additional not elementary logic.

I don't see the issue, orientation is a property of the connector itself,
even if it's provided by another ic.

Neil

> > +
> >     # The following are optional properties for "usb-c-connector" with power
> >     # delivery support.
> >     source-pdos: