Re: [PATCH v1] mtd: rawnand: meson: fix ready/busy command

From: Arseniy Krasnov
Date: Mon Jun 05 2023 - 02:45:07 EST


Hello Miquel!

I exclude this patch from the recent Meson patchset, as it is fix and not related to another patches.
Also I think that I can split Meson patchset (from links below) in the following way:
1) Patch/patchset for OOB layout
2) Patchset for "nand-rb" logic (meson_nand.c + DT bindings)
These two can also go independently:
3) https://lore.kernel.org/linux-mtd/20230601061850.3907800-6-AVKrasnov@xxxxxxxxxxxxxx/
4) https://lore.kernel.org/linux-mtd/20230601061850.3907800-7-AVKrasnov@xxxxxxxxxxxxxx/

What do You think?

Thanks, Arseniy

On 05.06.2023 09:10, Arseniy Krasnov wrote:
> Fix the ready/busy command value.
>
> Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> Cc: stable@xxxxxxxxxxxxxxx
> Suggested-by: Liang Yang <liang.yang@xxxxxxxxxxx>
> Signed-off-by: Arseniy Krasnov <AVKrasnov@xxxxxxxxxxxxxx>
> ---
> drivers/mtd/nand/raw/meson_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 074e14225c06..9dd4a676497b 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -37,7 +37,7 @@
> #define NFC_CMD_SCRAMBLER_ENABLE BIT(19)
> #define NFC_CMD_SCRAMBLER_DISABLE 0
> #define NFC_CMD_SHORTMODE_DISABLE 0
> -#define NFC_CMD_RB_INT BIT(14)
> +#define NFC_CMD_RB_INT ((0xb << 10) | BIT(18) | BIT(16))
>
> #define NFC_CMD_GET_SIZE(x) (((x) >> 22) & GENMASK(4, 0))
>