Re: [PATCH v4] Add .editorconfig file for basic formatting

From: Miguel Ojeda
Date: Sun Jun 04 2023 - 16:54:20 EST


On Fri, Jun 2, 2023 at 5:37 PM Mickaël Salaün <mic@xxxxxxxxxxx> wrote:
>
> Looks good to me, thanks!
>
> Acked-by: Mickaël Salaün <mic@xxxxxxxxxxx>
>
> It would be nice to have a script to check files and output a diff if
> they are not in line with this configuration. That could also be used to
> measure how many files are compliant with these rules, and add this
> stats in the commit message.

Agreed.

> For some reasons, maintainers may want to exclude some files from these
> constraints. It would be useful to add some documentation explaining how
> to do it.

I would suggest adding it directly as a comment on top of the
`.editorconfig` file itself. Or, at least, put there the link to the
official page (https://editorconfig.org), which mentions `unset`,
assuming that is the way to do so.

Íñigo, I would also suggest sending the patch to Andrew Morton.

Cheers,
Miguel