Re: [PATCH] cdx: Drop useless LIST_HEAD
From: kernel test robot
Date: Sun Jun 04 2023 - 04:42:26 EST
Hi Christophe,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.4-rc4 next-20230602]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christophe-JAILLET/cdx-Drop-useless-LIST_HEAD/20230604-124432
base: linus/master
patch link: https://lore.kernel.org/r/cee692c7babd754c1c36186af116c4bb4dad0a17.1685853842.git.christophe.jaillet%40wanadoo.fr
patch subject: [PATCH] cdx: Drop useless LIST_HEAD
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230604/202306041613.FCYOdhUW-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0836d9a86cf6d803585f7d9810ec8622ec81b2f7
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Christophe-JAILLET/cdx-Drop-useless-LIST_HEAD/20230604-124432
git checkout 0836d9a86cf6d803585f7d9810ec8622ec81b2f7
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306041613.FCYOdhUW-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/cdx/controller/mcdi.c: In function 'cdx_mcdi_process_cmd':
>> drivers/cdx/controller/mcdi.c:637:64: error: 'cleanup_list' undeclared (first use in this function)
637 | cdx_mcdi_complete_cmd(mcdi, cmd, outbuf, len, &cleanup_list);
| ^~~~~~~~~~~~
drivers/cdx/controller/mcdi.c:637:64: note: each undeclared identifier is reported only once for each function it appears in
vim +/cleanup_list +637 drivers/cdx/controller/mcdi.c
eb96b740192b2a0 Nipun Gupta 2023-03-13 609
eb96b740192b2a0 Nipun Gupta 2023-03-13 610 void cdx_mcdi_process_cmd(struct cdx_mcdi *cdx, struct cdx_dword *outbuf, int len)
eb96b740192b2a0 Nipun Gupta 2023-03-13 611 {
eb96b740192b2a0 Nipun Gupta 2023-03-13 612 struct cdx_mcdi_iface *mcdi;
eb96b740192b2a0 Nipun Gupta 2023-03-13 613 struct cdx_mcdi_cmd *cmd;
eb96b740192b2a0 Nipun Gupta 2023-03-13 614 unsigned int respseq;
eb96b740192b2a0 Nipun Gupta 2023-03-13 615
eb96b740192b2a0 Nipun Gupta 2023-03-13 616 if (!len || !outbuf) {
eb96b740192b2a0 Nipun Gupta 2023-03-13 617 pr_err("Got empty MC response\n");
eb96b740192b2a0 Nipun Gupta 2023-03-13 618 return;
eb96b740192b2a0 Nipun Gupta 2023-03-13 619 }
eb96b740192b2a0 Nipun Gupta 2023-03-13 620
eb96b740192b2a0 Nipun Gupta 2023-03-13 621 mcdi = cdx_mcdi_if(cdx);
eb96b740192b2a0 Nipun Gupta 2023-03-13 622 if (!mcdi)
eb96b740192b2a0 Nipun Gupta 2023-03-13 623 return;
eb96b740192b2a0 Nipun Gupta 2023-03-13 624
eb96b740192b2a0 Nipun Gupta 2023-03-13 625 respseq = CDX_DWORD_FIELD(outbuf[0], MCDI_HEADER_SEQ);
eb96b740192b2a0 Nipun Gupta 2023-03-13 626
eb96b740192b2a0 Nipun Gupta 2023-03-13 627 mutex_lock(&mcdi->iface_lock);
eb96b740192b2a0 Nipun Gupta 2023-03-13 628 cmd = mcdi->seq_held_by[respseq];
eb96b740192b2a0 Nipun Gupta 2023-03-13 629
eb96b740192b2a0 Nipun Gupta 2023-03-13 630 if (cmd) {
eb96b740192b2a0 Nipun Gupta 2023-03-13 631 if (cmd->state == MCDI_STATE_FINISHED) {
eb96b740192b2a0 Nipun Gupta 2023-03-13 632 mutex_unlock(&mcdi->iface_lock);
eb96b740192b2a0 Nipun Gupta 2023-03-13 633 kref_put(&cmd->ref, cdx_mcdi_cmd_release);
eb96b740192b2a0 Nipun Gupta 2023-03-13 634 return;
eb96b740192b2a0 Nipun Gupta 2023-03-13 635 }
eb96b740192b2a0 Nipun Gupta 2023-03-13 636
eb96b740192b2a0 Nipun Gupta 2023-03-13 @637 cdx_mcdi_complete_cmd(mcdi, cmd, outbuf, len, &cleanup_list);
eb96b740192b2a0 Nipun Gupta 2023-03-13 638 } else {
eb96b740192b2a0 Nipun Gupta 2023-03-13 639 pr_err("MC response unexpected for seq : %0X\n", respseq);
eb96b740192b2a0 Nipun Gupta 2023-03-13 640 }
eb96b740192b2a0 Nipun Gupta 2023-03-13 641
eb96b740192b2a0 Nipun Gupta 2023-03-13 642 mutex_unlock(&mcdi->iface_lock);
eb96b740192b2a0 Nipun Gupta 2023-03-13 643
eb96b740192b2a0 Nipun Gupta 2023-03-13 644 cdx_mcdi_process_cleanup_list(mcdi->cdx, &cleanup_list);
eb96b740192b2a0 Nipun Gupta 2023-03-13 645 }
eb96b740192b2a0 Nipun Gupta 2023-03-13 646
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki