Re: [PATCH v3 2/3] KVM: x86: Retry APIC optimized map recalc if vCPU is added/enabled

From: Michal Luczaj
Date: Sat Jun 03 2023 - 21:04:51 EST


On 6/3/23 01:32, Sean Christopherson wrote:
> + * Read kvm->arch.apic_map_dirty before kvm->arch.apic_map (if clean)
> + * or the APIC registers (if dirty). Note, on retry the map may have
> + * not yet been marked dirty by whatever task changed a vCPU's x2APIC
> + * ID, i.e. the map may still show up as in-progress. In that case
> + * this task still needs to retry and copmlete its calculation.

s/copmlete/complete ?

Speaking of nits, if you're planning to do some more work around
kvm_recalculate_phys_map(), there's that old comment typo I've failed
to notice earlier:

"Apply KVM's hotplug hack if userspace has enable 32-bit APIC IDs."

enabled?