Re: [PATCH v5 2/7] iio: light: vcnl4000: Add proximity ps_it for vcnl4200

From: andy . shevchenko
Date: Sat Jun 03 2023 - 08:09:24 EST


Tue, May 30, 2023 at 04:24:00PM +0200, Astrid Rost kirjoitti:
> Add ps_it attributes for vcnl4200 (similar to vcnl4040).
> Add read/write attribute for proximity integration time.
> Read attribute for available proximity integration times.
> Change sampling rate depending on integration time.

...

> irqreturn_t (*irq_thread)(int irq, void *priv);
> irqreturn_t (*trig_buffer_func)(int irq, void *priv);
> u8 int_reg;

+ Blank line?

> + const int(*ps_it_times)[][2];
> + const int num_ps_it_times;


--
With Best Regards,
Andy Shevchenko