Re: [PATCH 1/1] page cache: fix page_cache_next/prev_miss off by one

From: Mike Kravetz
Date: Fri Jun 02 2023 - 22:25:10 EST


On 06/02/23 17:59, Andrew Morton wrote:
> On Fri, 2 Jun 2023 15:57:47 -0700 Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote:
>
> > Ackerley Tng reported an issue with hugetlbfs fallocate here[1]. The
> > issue showed up after the conversion of hugetlb page cache lookup code
> > to use page_cache_next_miss.
>
> So I'm assuming
>
> Fixes: d0ce0e47b323 ("mm/hugetlb: convert hugetlb fault paths to use alloc_hugetlb_folio()")
>

Yes, that would be preferred.

I originally had Fixes: 0d3f92966629 ("page cache: Convert hole search to
XArray") where page_cache_next/prev_miss were introduced. But, there is
no issue until the new hugetlb usage.
--
Mike Kravetz