Re: [PATCH v4] watchdog: Allow nmi watchdog to use "ref-cycles" event

From: Song Liu
Date: Fri Jun 02 2023 - 18:12:01 EST


Hi Andrew and Peter,

Friendly ping... Any comment on this one?

Thanks,
Song

> On May 25, 2023, at 3:20 PM, Song Liu <songliubraving@xxxxxxxx> wrote:
>
> Hi Andrew and Peter,
>
>
>> On May 19, 2023, at 9:59 AM, Song Liu <songliubraving@xxxxxxxx> wrote:
>>
>> Hi Andrew and Peter,
>>
>> Does this version look good do you?
>>
>> Thanks,
>> Song
>>
>>> On May 17, 2023, at 5:25 PM, Song Liu <song@xxxxxxxxxx> wrote:
>>>
>>> NMI watchdog permanently consumes one hardware counters per CPU on the
>>> system. For systems that use many hardware counters, this causes more
>>> aggressive time multiplexing of perf events.
>>>
>>> OTOH, some CPUs (mostly Intel) support "ref-cycles" event, which is rarely
>>> used. Add kernel cmdline arg nmi_watchdog=ref-cycles to configure the
>>> watchdog to use "ref-cycles" event instead of "cycles".
>>>
>>> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>>> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>>> Signed-off-by: Song Liu <song@xxxxxxxxxx>
>
> Could you please share your comments on this patch?
>
> Thanks,
> Song