Re: [PATCH v1 26/43] pata: cirrus: add DT support for Cirrus EP93xx

From: Sergey Shtylyov
Date: Fri Jun 02 2023 - 16:03:53 EST


Hello!

On 6/1/23 8:45 AM, Nikita Shubin wrote:

> - find register range from the device tree
> - get interrupts from device tree

Hm... I'm not seeing such changes in your patch?

> Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
> ---
>
> Notes:
> v0 -> v1:
>
> - fixed headers
> - dropped coma in id table
>
> drivers/ata/pata_ep93xx.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c
> index c6e043e05d43..8d363bc71342 100644
> --- a/drivers/ata/pata_ep93xx.c
> +++ b/drivers/ata/pata_ep93xx.c
> @@ -40,6 +40,7 @@
> #include <linux/ata.h>
> #include <linux/libata.h>
> #include <linux/platform_device.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/delay.h>
> #include <linux/dmaengine.h>
> #include <linux/ktime.h>
> @@ -1016,9 +1017,16 @@ static int ep93xx_pata_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct of_device_id ep93xx_pata_of_ids[] = {
> + { .compatible = "cirrus,ep9312-pata" },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, ep93xx_pata_of_ids);
> +
> static struct platform_driver ep93xx_pata_platform_driver = {
> .driver = {
> .name = DRV_NAME,
> + .of_match_table = ep93xx_pata_of_ids,
> },
> .probe = ep93xx_pata_probe,
> .remove = ep93xx_pata_remove,

MBR, Sergey