Re: [PATCH 4/4] tools/testing/cxl: add firmware update emulation to CXL memdevs

[Verma, Vishal L]

On Thu, 2023-05-11 at 17:18 +0100, Jonathan Cameron wrote:
> 
> ...

Addressed everything else for v2

> 
> > +static int do_sha256(u8 *data, unsigned int length, u8 *hash)
> 
> Can't use the one in include/crypto/sha2.h?  Don't think anyone really
> cares about extreme performance here.
> 
> 
Ah nice, I hadn't seen that before. I was slightly concerned by the
comment there saying this is really only for kexec, and the other
interfaces were more document/prevalent. But using the interfaces in
include/crypto/sha2.h made the code a whole lot easier to follow /
maintain, so I've gone forward with it. We can always switch back later
if need be.