Re: [PATCH v2 01/13] fs: export mnt_idmap_get/mnt_idmap_put

From: Christian Brauner
Date: Fri Jun 02 2023 - 08:40:45 EST


On Wed, May 24, 2023 at 05:33:03PM +0200, Alexander Mikhalitsyn wrote:
> These helpers are required to support idmapped mounts in the Cephfs.
>
> Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@xxxxxxxxxxxxx>
> ---

It's fine by me to export them. The explicit contract is that _nothing
and absolutely nothing_ outside of core VFS code can directly peak into
struct mnt_idmap internals. That's the only invariant we care about.o

Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>