Re: [PATCH 1/2] mm/memory_hotplug: remove reset_node_managed_pages() in hotadd_init_pgdat()

[David Hildenbrand]

On 01.06.23 18:26, Haifeng Xu wrote:
> managed pages has already been set to 0 in free_area_init_core_hotplug(),

"via zone_init_internals() on each zone"

> so it's pointless to reset again.
>
> Signed-off-by: Haifeng Xu <haifeng.xu@xxxxxxxxxx>
> ---
>   mm/memory_hotplug.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 8e0fa209d533..65e385f34679 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1210,7 +1210,6 @@ static pg_data_t __ref *hotadd_init_pgdat(int nid)
>   	 * online_pages() and offline_pages().
>   	 * TODO: should be in free_area_init_core_hotplug?
>   	 */
> -	reset_node_managed_pages(pgdat);
>   	reset_node_present_pages(pgdat);
>   
>   	return pgdat;

With that, reset_node_managed_pages() no longer needs to be exposed 
outside of mm/memblock.c

Can you unexport that function as well?

--
Thanks,

David / dhildenb