Re: [PATCH 2/4] ACPI/APMT: Don't register invalid resource
From: Suzuki K Poulose
Date: Fri Jun 02 2023 - 06:31:54 EST
On 01/06/2023 12:59, Robin Murphy wrote:
Don't register a resource for the second page unless the dual-page
extension flag is actually present to say it's valid.
CC: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>
CC: Hanjun Guo <guohanjun@xxxxxxxxxx>
CC: Sudeep Holla <sudeep.holla@xxxxxxx>
Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>
---
Not a critical fix, since the driver currently works around this itself,
but patch #4 would like to clean that up.
drivers/acpi/arm64/apmt.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/arm64/apmt.c b/drivers/acpi/arm64/apmt.c
index 8cab69fa5d59..aa7d5c3c0dd8 100644
--- a/drivers/acpi/arm64/apmt.c
+++ b/drivers/acpi/arm64/apmt.c
@@ -35,11 +35,13 @@ static int __init apmt_init_resources(struct resource *res,
num_res++;
- res[num_res].start = node->base_address1;
- res[num_res].end = node->base_address1 + SZ_4K - 1;
- res[num_res].flags = IORESOURCE_MEM;
+ if (node->flags & ACPI_APMT_FLAGS_DUAL_PAGE) {
+ res[num_res].start = node->base_address1;
+ res[num_res].end = node->base_address1 + SZ_4K - 1;
+ res[num_res].flags = IORESOURCE_MEM;
- num_res++;
+ num_res++;
+ }
if (node->ovflw_irq != 0) {
trigger = (node->ovflw_irq_flags & ACPI_APMT_OVFLW_IRQ_FLAGS_MODE);
Reviewed-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>