Re: [PATCH v2 1/5] dt-bindings: arm: ti: add toradex,verdin-am62 et al.

From: Francesco Dolcini
Date: Fri Jun 02 2023 - 04:18:46 EST


On Fri, Jun 02, 2023 at 10:20:45AM +0300, Tony Lindgren wrote:
> Hi,
>
> * Francesco Dolcini <francesco@xxxxxxxxxx> [230601 13:15]:
> > From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> >
> > Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its
> > nonwifi and wifi variants and the carrier boards (Dahlia,
> > Verdin Development Board and Yavia) they may be mated in.
>
> Looks like you have wifi on sdio, there should be no need for separate
> compatible properties. The sdio wifi will try to probe and will just bail
> out if no wifi is populated.
>
> If however the non-wifi variants are recycling the sdio pins for something
> else, then it's it's a different story. In that case you want either
> seprate compatible properties, or want to use dts fragments possibly.

This is exactly the case, the wifi/non-wifi variant are re-using pins.

I provided a more verbose explanation on that on a previous discussion
https://lore.kernel.org/all/ZG5jYV%2FNfGJvYkma@xxxxxxxxxxxxxxxxxxxxxxxxxxxx/

Francesco