Re: [PATCH 0/3] thermal/drivers/mediatek/lvts_thermal: Fixes to the interrupt handling

[Daniel Lezcano]

On 30/05/2023 21:46, Nícolas F. R. A. Prado wrote:
> On Tue, May 30, 2023 at 02:27:36PM +0200, Daniel Lezcano wrote:
> > Hi,
> >
> > On 02/05/2023 12:33, Chen-Yu Tsai wrote:
> > > On Fri, Apr 28, 2023 at 03:53:44PM -0400, Nícolas F. R. A. Prado wrote:
> > > > Fixes in the interrupt handling of the LVTS thermal driver noticed while
> > > > testing it on the Spherion Chromebook (mt8192-asurada-spherion) with the
> > > > MT8192 support series [1].
> > > >
> > > > These are standalone fixes and don't depend on anything else.
> > > >
> > > > [1] https://lore.kernel.org/all/20230307163413.143334-1-bchihi@xxxxxxxxxxxx/
> > > >
> > > > Thanks,
> > > > Nícolas
> > > >
> > > >
> > > > Nícolas F. R. A. Prado (3):
> > > >     thermal/drivers/mediatek/lvts_thermal: Handle IRQ on all controllers
> > > >     thermal/drivers/mediatek/lvts_thermal: Honor sensors in immediate mode
> > > >     thermal/drivers/mediatek/lvts_thermal: Disable undesired interrupts
> > >
> > > This series seems to have solved all interrupt storm issue I ran into, so
> > >
> > > Tested-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
> >
> > I gave a try on a mt8195 board and I don't see any interrupt firing when
> > crossing the temperature thresholds.
> >
> > Did I miss something ?
>
> No, indeed interrupts seem to be completely disabled on mt8195, even after
> setting the controllers to filtered mode (a requirement to get interrupts).

Really? interrupts work only on filtered mode? That sounds strange

What board are you using for testing?

> I
> haven't investigated that further yet. This series was validated on mt8192,
> which did have working interrupts, but they were being triggered too often.

Ok.

> Also note that I've sent a v2 with even more fixes:
> https://lore.kernel.org/all/20230504004852.627049-1-nfraprado@xxxxxxxxxxxxx/

Yes, I'm reviewing it closely

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog