Re: [PATCH] certs/extract-cert: Fix checkpatch issues

From: kernel test robot
Date: Thu Jun 01 2023 - 23:10:10 EST


Hi Franziska,

kernel test robot noticed the following build errors:

[auto build test ERROR on 7877cb91f1081754a1487c144d85dc0d2e2e7fc4]

url: https://github.com/intel-lab-lkp/linux/commits/Franziska-Naepelt/certs-extract-cert-Fix-checkpatch-issues/20230602-030657
base: 7877cb91f1081754a1487c144d85dc0d2e2e7fc4
patch link: https://lore.kernel.org/r/20230601190508.56610-1-franziska.naepelt%40gmail.com
patch subject: [PATCH] certs/extract-cert: Fix checkpatch issues
config: arm-randconfig-r046-20230531 (https://download.01.org/0day-ci/archive/20230602/202306021102.zQU95cMI-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7fdfaec7a3c9f58676a5892e679d8bca319abd8a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Franziska-Naepelt/certs-extract-cert-Fix-checkpatch-issues/20230602-030657
git checkout 7fdfaec7a3c9f58676a5892e679d8bca319abd8a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306021102.zQU95cMI-lkp@xxxxxxxxx/

All error/warnings (new ones prefixed by >>):

>> certs/extract-cert.c:36:18: error: expected ';' before 'void'
36 | static __noreturn
| ^
| ;
37 | void format(void)
| ~~~~
>> certs/extract-cert.c:37:6: warning: no previous prototype for 'format' [-Wmissing-prototypes]
37 | void format(void)
| ^~~~~~


vim +36 certs/extract-cert.c

35
> 36 static __noreturn
> 37 void format(void)
38 {
39 fprintf(stderr,
40 "Usage: extract-cert <source> <dest>\n");
41 exit(2);
42 }
43

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki