Re: [Intel-gfx] [PATCH] drm/i915/pxp: use correct format string for size_t

From: Teres Alexis, Alan Previn
Date: Thu Jun 01 2023 - 18:00:36 EST


On Thu, 2023-06-01 at 23:36 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> While 'unsigned long' needs the %ld format string, size_t needs the %z
> modifier:

alan:snip


> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c
> @@ -143,7 +143,7 @@ gsccs_send_message(struct intel_pxp *pxp,
>
> reply_size = header->message_size - sizeof(*header);
> if (reply_size > msg_out_size_max) {
> - drm_warn(&i915->drm, "caller with insufficient PXP reply size %u (%ld)\n",
> + drm_warn(&i915->drm, "caller with insufficient PXP reply size %u (%zd)\n",
> reply_size, msg_out_size_max);
> reply_size = msg_out_size_max;
> }
Thanks Arnd for catching this, although i believe Nathan sumbmitted a patch for the same fix yesterday and received an RB from Andi.