Re: [PATCH v2] riscv/purgatory: Do not use fortified string functions

[Palmer Dabbelt]

On Thu, 01 Jun 2023 13:31:33 PDT (-0700), keescook@xxxxxxxxxxxx wrote:
> On Thu, Jun 01, 2023 at 01:17:03PM -0700, Palmer Dabbelt wrote:
> > On Thu, 01 Jun 2023 11:27:03 PDT (-0700), keescook@xxxxxxxxxxxx wrote:
> > > On Thu, 1 Jun 2023 09:00:28 -0700, Kees Cook wrote:
> > > > With the addition of -fstrict-flex-arrays=3, struct sha256_state's
> > > > trailing array is no longer ignored by CONFIG_FORTIFY_SOURCE:
> > > >
> > > > struct sha256_state {
> > > >         u32 state[SHA256_DIGEST_SIZE / 4];
> > > >         u64 count;
> > > >         u8 buf[SHA256_BLOCK_SIZE];
> > > > };
> > > >
> > > > [...]
> > >
> > > Applied to for-next/hardening, thanks!
> > >
> > > [1/1] riscv/purgatory: Do not use fortified string functions
> > >       https://git.kernel.org/kees/c/ca2ca08f479d
> >
> > Sorry, I'd just applied this to riscv/fixes as well.  I can drop it if you
> > want?  I was going to send a PR tomorrow, just LMK.
>
> I'm fine either way. I was carrying each arch's fix just since it was
> related to the -fstrict-flex-arrays=3 patch in the hardening tree.

Works for me, I'll drop it.

Reviewed-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>

The bots will probably get confussed and it was briefly visible to 
linux-next, so there might be a bit of spam.