Re: [PATCH V2 04/13] dt-bindings: clock: qcom: gcc-ipq5018: remove q6 clocks macros

From: Robert Marko
Date: Thu Jun 01 2023 - 14:56:02 EST


On 30. 05. 2023. 13:01, Krzysztof Kozlowski wrote:

On 22/05/2023 00:28, Manikanta Mylavarapu wrote:
Since Q6 firmware takes care of bring up clocks in multipd
model, remove bring up clock macros.

Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
---
include/dt-bindings/clock/qcom,gcc-ipq5018.h | 21 --------------------
1 file changed, 21 deletions(-)

I am fine with this if it still compiles... I have doubts about it,
unless of some depedencies (you mentioned three !)... but then it gets
complicated.

Keep patches doing same logical change in same patchset. This dependency
dance in recent submissions is making things tricky and prolonging your
upstreaming process significantly.

Considering that the basic IPQ5018 patchset that this series depends on
has not yet been merged, why not just drop these there instead?

Regards,
Robert


Best regards,
Krzysztof