Re: [PATCH v4 5/6] connector/cn_proc: Performance improvements

[Anjali Kulkarni]

> On Jun 1, 2023, at 9:48 AM, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> 
> On Thu, 1 Jun 2023 16:38:04 +0000 Anjali Kulkarni wrote:
>>> The #define FILTER and ifdefs around it need to go, this much I can
>>> tell you without understanding what it does :S We have the git history
>>> we don't need to keep dead code around.  
>> 
>> The FILTER option is for backwards compatibility for those who may be
>> using the proc connector today - so they do not need to immediately
>> switch to using the new method - the example just shows the old
>> method which does not break or need changes - do you still want me to
>> remove the FILTER? 
> 
> Is it possible to recode the sample so the format can be decided based
> on cmd line argument? To be honest samples are kinda dead, it'd be best
> if the code was rewritten to act as a selftest.

Yes, I can recode to use a cmd line argument. Where would a selftest be committed? This is kind of a self test in the sense that this is working code  to test the other kernel code. What else is needed to make it a selftest?

Anjali