Re: [PATCH 2/2] powerpc/xmon: use KSYM_NAME_LEN in array size

From: Michael Ellerman
Date: Thu Jun 01 2023 - 08:55:03 EST


Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> writes:
> On Thu, Jun 1, 2023 at 4:02 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>>
>> > Side-note: in `get_function_bounds()`, I see `kallsyms_lookup()` being
>> > used, but the name seems discarded? Can
>> > `kallsyms_lookup_size_offset()` be used instead, thus avoiding the
>> > usage of the buffer there to begin with?
>>
>> A few lines below it uses the modname, and AFAICS there's no (easy) way
>> to lookup the modname without also looking up the name.
>
> Hmm... I think you are looking at the `xmon_print_symbol()` one? I was
> referring to the `get_function_bounds()` one, where the `modname`
> parameter is `NULL` (and the `name` contents are not used, only
> whether it was found or not).

Yes you're right, apparently I can't read :}

cheers