Re: [PATCH] arm64: dts: ti: k3-j784s4: Fix wakeup pinmux range and pinctrl node offsets

[Thejasvi Konduru]

On 09/05/23 15:19, Thejasvi Konduru wrote:
> On 04/05/23 19:52, Nishanth Menon wrote:
> > On 17:40-20230504, Thejasvi Konduru wrote:
> > > On 04/05/23 17:22, Nishanth Menon wrote:
> > > > On 14:36-20230504, Thejasvi Konduru wrote:
> > > > > On 03/05/23 17:16, Nishanth Menon wrote:
> > > > > > On 14:01-20230503, Thejasvi Konduru wrote:
> > > > > > > The wkup_pmx register region in j784s4 has multiple non-addressable
> > > > > > > regions, hence the existing wkup_pmx region is split as follows to
> > > > > > > avoid the non-addressable regions. The pinctrl node offsets are
> > > > > > > also corrected as per the newly split wkup_pmx* nodes.
> > > > > > >
> > > > > > > wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
> > > > > > > wkup_pmx1 -> 11 pins (WKUP_PADCONFIG 14 - 24)
> > > > > > > wkup_pmx2 -> 72 pins (WKUP_PADCONFIG 26 - 97)
> > > > > > > wkup_pmx3 -> 1 pin (WKUP_PADCONFIG 100)
> > > > > > >
> > > > > > > Fixes: 4664ebd8346a ("arm64: dts: ti: Add initial support for 
> > > > > > > J784S4 SoC")
> > > > > > > Signed-off-by: Thejasvi Konduru <t-konduru@xxxxxx>
> > > > > > > ---
> > > > > > Could you provide a link to the output of:
> > > > > > $ cat /sys/kernel/debug/pinctrl/*/pins
> > > > > https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a 
> > > > Was this failing prior to this patch? Trying to understand the "Fix"
> > > > aspect of this patch.
> > > Yes,it was failing prior to this patch.
> > next time some asks this question - give summary AND give a log. Even
> > better, please don't make folks even ask the question in the first
> > place by including the logs in the diffstat of the patch.
> >
> > Please share the log to understand what kind of "failure" was occurring.
>
> Link to logs:
> Before Fix: 
> https://gist.github.com/thejasvikonduru/e217edf4839c348793a5671aa9331595
> After Fix : 
> https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a
Are these logs fine and can we go forward with this patch?