Re: [PATCH] serial: core: Don't drop port_mutex in serial_core_remove_one_port

From: Tony Lindgren
Date: Thu Jun 01 2023 - 06:58:31 EST


* Steven Price <steven.price@xxxxxxx> [230601 10:56]:
> Commit 84a9582fd203 ("serial: core: Start managing serial controllers to
> enable runtime PM") required the caller to hold port_mutex rather than
> taking it locally. However the mutex_unlock() call wasn't removed
> causing the mutex to be dropped unexpectly. Remove the call to
> mutex_unlock() (and fix up the early return) to restore correct
> behaviour.
>
> Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")

Reviewed-by: Tony Lindgren <tony@xxxxxxxxxxx>