Re: [PATCH 0/8] media: mediatek: vcodec: separate encoder and decoder

From: AngeloGioacchino Del Regno
Date: Thu Jun 01 2023 - 05:32:39 EST


Il 01/06/23 05:02, Yunfei Dong ha scritto:
With the driver more and more complex, encoder and decoder need to add more parameter
in shared struct 'mtk_vcodec_ctx' and 'mtk_vcodec_dev'. Encoder use about 40% and
decoder use 60% parameter. Need to allocate extra unused memory when encoder and decoder
working.

Separate encoder and decoder in different folder and use independent data struct.


Great cleanup initiative! Love it!

My sugggestion here is to change the new folder names to drop "video-":
this is already in folder vcodec/ which means that it is video codec related.

So, instead of having folders "video-common", "video-decoder", "video-encoder",
we should have "common", "decoder", "encoder" instead.

Cheers,
Angelo