Re: [PATCH] vfio/pci: demote hiding ecap messages to debug level

[Alex Williamson]

On Thu,  4 May 2023 15:16:54 +0200
Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx> wrote:

> Seeing a burst of messages like this:
> 
>     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0
>     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200
>     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210
>     vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250
>     vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200
>     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0
>     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200
>     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210
>     vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250
>     vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200
> 
> is of little to no value for an ordinary user.
> 
> Hence, use pci_dbg() instead of pci_info().
> 
> Signed-off-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>
> ---
>  drivers/vfio/pci/vfio_pci_config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
> index 948cdd464f4e..dd8dda14e701 100644
> --- a/drivers/vfio/pci/vfio_pci_config.c
> +++ b/drivers/vfio/pci/vfio_pci_config.c
> @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev)
>  		}
>  
>  		if (!len) {
> -			pci_info(pdev, "%s: hiding ecap %#x@%#x\n",
> +			pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n",
>  				 __func__, ecap, epos);
>  
>  			/* If not the first in the chain, we can skip over it */

Applied to vfio next branch for v6.5.  Thanks!

Alex