Re: [PATCH 1/2][next] scsi: lpfc: Replace one-element array with flexible-array member

From: Gustavo A. R. Silva
Date: Tue May 23 2023 - 15:47:39 EST




On 5/23/23 11:31, Kees Cook wrote:
On Mon, May 22, 2023 at 06:02:21PM -0400, Martin K. Petersen wrote:

Gustavo,

One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element arrays with flexible-array
members in a couple of structures, and refactor the rest of the code,
accordingly.

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [1].

This results in no differences in binary output.

Applied to 6.5/scsi-staging, thanks!

Martin, I think this patch is not right -- can you drop this from
staging for the moment?

Martin just took patch 1/2, which is correct:

https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=6.5/scsi-staging&id=e90644b0ce2d700a65579ac74ff594414e8ba30f

--
Gustavo