Re: [PATCH V4 4/6] coresight: etm4x: Change etm4_platform_driver driver for MMIO devices

From: Sudeep Holla
Date: Tue May 23 2023 - 11:17:26 EST


On Tue, May 23, 2023 at 10:15:51AM +0530, Anshuman Khandual wrote:
> Add support for handling MMIO based devices via platform driver. We need to
> make sure that :
>
> 1) The APB clock, if present is enabled at probe and via runtime_pm ops

Was mainly interested in the above to ensure it works smoothly once migrate
to this with ACPI. The changes look good to me.

So,

Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>

--
Regards,
Sudeep