Re: [PATCH 4.14] netfilter: nf_tables: fix register ordering

From: Pablo Neira Ayuso
Date: Tue May 23 2023 - 04:45:33 EST


On Mon, May 22, 2023 at 07:59:41PM -0700, Andrew Paniakin wrote:
> From: Florian Westphal <fw@xxxxxxxxx>
>
> commit d209df3e7f7002d9099fdb0f6df0f972b4386a63 upstream
>
> [ We hit the trace described in commit message with the
> kselftest/nft_trans_stress.sh. This patch diverges from the upstream one
> since kernel 4.14 does not have following symbols:
> nft_chain_filter_init, nf_tables_flowtable_notifier ]
>
> We must register nfnetlink ops last, as that exposes nf_tables to
> userspace. Without this, we could theoretically get nfnetlink request
> before net->nft state has been initialized.

I have to send pending batch of updates for -stable 4.14.

I take this patch and I will pass it on -stable maintainers.

Thanks.