Re: [PATCH 3/5] sched: fair: hide unused init_cfs_bandwidth() stub

[Mukesh Ojha]

On 5/23/2023 1:20 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> init_cfs_bandwidth() is only used when CONFIG_FAIR_GROUP_SCHED is
> enabled, and without this causes a W=1 warning for the missing prototype:
>
> kernel/sched/fair.c:6131:6: error: no previous prototype for 'init_cfs_bandwidth'
>
> The normal implementation is only defined for CONFIG_CFS_BANDWIDTH,
> so the stub exists when CFS_BANDWIDTH is disabled but FAIR_GROUP_SCHED
> is enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>


Reviewed-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>

-- Mukesh

> ---
>   kernel/sched/fair.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 2c1b345c3b8d..a7a8ccde3bd7 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -6169,9 +6169,8 @@ static inline int throttled_lb_pair(struct task_group *tg,
>   	return 0;
>   }
>   
> -void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
> -
>   #ifdef CONFIG_FAIR_GROUP_SCHED
> +void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
>   static void init_cfs_rq_runtime(struct cfs_rq *cfs_rq) {}
>   #endif
>