Re: [PATCH] cifs: Fix cifs_limit_bvec_subset() to correctly check the maxmimum size

From: Steve French
Date: Tue May 23 2023 - 02:45:41 EST


On Mon, May 22, 2023 at 1:11 PM David Howells <dhowells@xxxxxxxxxx> wrote:
>
> Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote:
>
> > > + max_size -= len;
> >
> > Shouldn't this decrement happen below, after the span has been
> > compared with max_size?
>
> It probably doesn't matter. The compiler is free to move it around, but yes
> that and ix++ can both be moved down.

I am not sure I follow - can you explain? It looks like moving it up
vs. down would change behavior


--
Thanks,

Steve