Re: [PATCH] md/raid5: Convert stripe_head's "dev" to flexible array member

From: Christoph Hellwig
Date: Tue May 23 2023 - 01:54:25 EST


On Mon, May 22, 2023 at 07:49:38PM +0800, Yu Kuai wrote:
> Hi, Christoph
>
> 在 2023/05/18 12:27, Christoph Hellwig 写道:
>
> It's not related to this patch, just I think I found a problem while
> reviewing raid5 code, commit e82ed3a4fbb5 ("md/raid6: refactor
> raid5_read_one_chunk") changes the caculation of 'end_sector',
> 'end_sector' is compared to 'rdev->recovery_offset', so it should be
> offset to rdev, but this commit change it to offset to the array.
>
> Perhaps following change will make sense:

Yes, I think it does. Can you send a patch?