Re: [PATCH v2 4/6] dt-bindings: phy: rockchip: rk3588 has two reset lines

From: Conor Dooley
Date: Mon May 22 2023 - 15:24:55 EST


Hey Sebastian,

On Mon, May 22, 2023 at 07:34:21PM +0200, Sebastian Reichel wrote:
> The RK3588 has two reset lines for the combphy. One for the
> APB interface and one for the actual PHY.

But the 68 only has one? Should per-compatible enforcement be added
like you added for the clocks?

> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> ---
> .../bindings/phy/phy-rockchip-naneng-combphy.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> index 9ae514fa7533..82550a5c2ed5 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> @@ -31,8 +31,14 @@ properties:
> - const: pipe
>
> resets:
> + minItems: 1
> + maxItems: 2
> +
> + reset-names:
> + minItems: 1
> items:
> - - description: exclusive PHY reset line
> + - const: phy
> + - const: apb
>
> rockchip,enable-ssc:
> type: boolean
> --
> 2.39.2
>

Attachment: signature.asc
Description: PGP signature