Re: [PATCH net-next 00/30] net: dsa: mt7530: improve, trap BPDU & LLDP, and prefer CPU port

From: Arınç ÜNAL
Date: Mon May 22 2023 - 10:36:50 EST


On 22/05/2023 17:09, Horatiu Vultur wrote:
The 05/22/2023 15:15, arinc9.unal@xxxxxxxxx wrote:

Hi,


Hello!

This patch series simplifies the code, improves the logic of the switch
hardware support, traps LLDP frames and BPDUs for MT7530, MT7531, and
MT7988 SoC switches, and introduces the preferring local CPU port
operation.

There's also a patch for fixing the port capabilities of the switch on the
MT7988 SoC.


I have noticed that in many patches of the series you have:
Tested-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>

Where you also have:
Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>

I think you can drop Tested-by as the SoB will imply that. I think you
got a similar comment some time ago to a different patch series.

Yes, that was for the net, therefore the stable tree. The very first rule for the patches going to the stable tree is that the patch must be tested.

I don't see a clear indication of the patches submitted to net-next being tested on the relevant hardware by the author. Therefore, I explicitly put my tag to state it. Let me know if you don't agree with this.

Arınç