Re: [PATCH v8 5/6] i2c: Add support for Intel LJCA USB I2C driver

From: Oliver Neukum
Date: Mon May 22 2023 - 05:50:27 EST




On 11.05.23 19:58, Ye Xiang wrote:
Implements the I2C function of Intel USB-I2C/GPIO/SPI adapter device
named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA I2c
module with specific protocol through interfaces exported by LJCA
USB driver.

+/* I2C Transfer */
+struct i2c_xfer {
+ u8 id;
+ u8 slave;
+ u16 flag; /* speed, 8/16bit addr, addr increase, etc */
+ u16 addr;
+ u16 len;
+ u8 data[];
+} __packed;

Where is this needed?
Why is it defined __packed, yet the internal endianness
is not declared?

Regards
Oliver