Re: [PATCH bpf-next] samples/bpf: hbm: Fix compile error about fallthrough marking

From: Daniel Borkmann
Date: Mon May 22 2023 - 04:47:50 EST


On 5/22/23 5:20 AM, Rong Tao wrote:
From: Rong Tao <rongtao@xxxxxxxx>

commit f7a858bffcdd("tools: Rename __fallthrough to fallthrough") rename
macro __fallthrough to fallthrough, commit 4b7ef71ac977("bpftool: Replace
"__fallthrough" by a comment to address merge conflict") use comments to
replace __fallthrough, here we can use fallthrough directly.

Compiling samples/bpf hits an error related to fallthrough marking:
...
CC samples/bpf/hbm.o
linux/samples/bpf/hbm.c: In function ‘main’:
linux/samples/bpf/hbm.c:501:25: error: ‘__fallthrough’ undeclared
(first use in this function); did you mean ‘fallthrough’?
501 | __fallthrough;
| ^~~~~~~~~~~~~
| fallthrough

Signed-off-by: Rong Tao <rongtao@xxxxxxxx>
---
samples/bpf/hbm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Fixed here already:

https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=a820ca1a739b7e3ee0ddb48bdfa3c09dc7cd4302