Re: [PATCH 4/4] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc

[Komal Bajaj]

On 5/20/2023 4:54 PM, Konrad Dybcio wrote:
> On 19.05.2023 12:13, Bhupesh Sharma wrote:
> > On 5/19/23 2:21 PM, Komal Bajaj wrote:
> > > Add sdhci node for emmc in qdu1000-idp.
> > >
> > > Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
> > > ---
> > >    arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 11 +++++++++++
> > >    1 file changed, 11 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > > index 9e9fd4b8023e..b2526e991548 100644
> > > --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > > +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> > > @@ -451,3 +451,14 @@
> > >    &uart7 {
> > >        status = "okay";
> > >    };
> > > +
> > > +&sdhc_1 {
> > > +    status = "okay";
> > > +
> > > +    pinctrl-0 = <&sdc1_on_state>;
> > > +    pinctrl-1 = <&sdc1_off_state>;
> > > +    pinctrl-names = "default", "sleep";
> > > +
> > > +    vmmc-supply = <&vreg_l10a_2p95>;
> > > +    vqmmc-supply = <&vreg_l7a_1p8>;
> > > +};
> > Again, please follow alphabetical order for adding new node entries.
Noted.
> > Also, we have been placing 'status = .. ' entry at the end for new .dts (or .dts entry), but if that is the format used across this board dts
> > I am ok with the same.
Sure, will move status to end.
> Komal,
>
> since you're already touching this file, would you mind making a
> separate commit moving status last for all nodes?
Hi Konrad,
I don't notice any other nodes whose state is maintained at the 
beginning of the node.

Thanks
Komal
> Konrad
> > Thanks,
> > Bhupesh