Re: [PATCH 23/31] mm/mglru: allow pte_offset_map_nolock() to fail

From: Yu Zhao
Date: Mon May 22 2023 - 01:27:28 EST

Next message: Hugh Dickins: "[PATCH 30/31] mm/pgtable: delete pmd_trans_unstable() and friends"
Previous message: Hugh Dickins: "[PATCH 29/31] mm/memory: handle_pte_fault() use pte_offset_map_nolock()"
In reply to: Hugh Dickins: "[PATCH 23/31] mm/mglru: allow pte_offset_map_nolock() to fail"
Next in thread: Hugh Dickins: "[PATCH 24/31] mm/migrate_device: allow pte_offset_map_lock() to fail"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, May 21, 2023 at 11:19 PM Hugh Dickins <hughd@xxxxxxxxxx> wrote:
>
> MGLRU's walk_pte_range() use the safer pte_offset_map_nolock(), rather
> than pte_lockptr(), to get the ptl for its trylock. Just return false
> and move on to next extent if it fails, like when the trylock fails.
> Remove the VM_WARN_ON_ONCE(pmd_leaf) since that will happen, rarely.
>
> Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>

Acked-by: Yu Zhao <yuzhao@xxxxxxxxxx>

Next message: Hugh Dickins: "[PATCH 30/31] mm/pgtable: delete pmd_trans_unstable() and friends"
Previous message: Hugh Dickins: "[PATCH 29/31] mm/memory: handle_pte_fault() use pte_offset_map_nolock()"
In reply to: Hugh Dickins: "[PATCH 23/31] mm/mglru: allow pte_offset_map_nolock() to fail"
Next in thread: Hugh Dickins: "[PATCH 24/31] mm/migrate_device: allow pte_offset_map_lock() to fail"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]