RE: [PATCH wireless-next v1 3/4] mmc: sdio: Add/rename SDIO ID of the RTL8723DS SDIO wifi cards

[Ping-Ke Shih]

> -----Original Message-----
> From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Sent: Friday, May 19, 2023 12:18 AM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: linux-mmc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; ulf.hansson@xxxxxxxxxx; kvalo@xxxxxxxxxx;
> tony0620emma@xxxxxxxxx; Peter Robinson <pbrobinson@xxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx>;
> jernej.skrabec@xxxxxxxxx; Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Subject: [PATCH wireless-next v1 3/4] mmc: sdio: Add/rename SDIO ID of the RTL8723DS SDIO wifi cards
> 
> RTL8723DS comes in two variant and each of them has their own SDIO ID:
> - 0xd723 can connect two antennas. The WiFi part is still 1x1 so the
>   second antenna can be dedicated to Bluetooth
> - 0xd724 can only connect one antenna so it's shared between WiFi and
>   Bluetooth
> 
> Add a new entry for the single antenna RTL8723DS (0xd724) which can be
> found on the MangoPi MQ-Quad. Also rename the existing RTL8723DS entry
> (0xd723) so it's name reflects that it's the variant with support for
> two antennas.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

> ---
>  include/linux/mmc/sdio_ids.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index c653accdc7fd..7fada7a714fe 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -121,7 +121,8 @@
>  #define SDIO_DEVICE_ID_REALTEK_RTW8822BS       0xb822
>  #define SDIO_DEVICE_ID_REALTEK_RTW8821CS       0xc821
>  #define SDIO_DEVICE_ID_REALTEK_RTW8822CS       0xc822
> -#define SDIO_DEVICE_ID_REALTEK_RTW8723DS       0xd723
> +#define SDIO_DEVICE_ID_REALTEK_RTW8723DS_2ANT  0xd723
> +#define SDIO_DEVICE_ID_REALTEK_RTW8723DS_1ANT  0xd724
>  #define SDIO_DEVICE_ID_REALTEK_RTW8821DS       0xd821
> 
>  #define SDIO_VENDOR_ID_SIANO                   0x039a
> --
> 2.40.1