[PATCH RFC 00/10] drm/panel: Drivers for four Sony CMD-mode (and DSC) panels

From: Marijn Suijten
Date: Sun May 21 2023 - 17:23:22 EST


Sending in a bunch of almost-finished (hence RFC) Sony panel drivers
upon drm/msm request, to further discussions around DSC panels and DSI
pclk calculations. This brings support for the following Sony Xperia
devices:

- Xperia XZ3 (DSC)
- Xperia 1 (DSC)
- Xperia 5
- Xperia 10 II (shared with Xperia 5)
- Xperia 5 II (DSC, 120Hz)

And, since the XZ3 already has all the DT in place to enable the panels
on its smaller XZ2(c) siblings, an extra patch is included to add the
new compatible string and properties to this device .dts. DTS for other
boards/platforms will come later, after cleaning up preliminary patches
(e.g. DPU catalog additions, SoC/board DTS for the MDSS subsystem, etc).

- File- and compatible names:

None of my downstream sources describe the product name of the panels
used here; in few cases the Display-IC is known but for the Xperia XZ3
Xperia 1 we have to make-do with a vendor name only.

Naming suggestions definitely welcome; i.e. I'm especially not fond of
sony-griffin-samsung.c :)

- Panels/drivers featuring multiple modes

As brought up earlier in #freedreno drm_panel drivers can provide
multiple modes, but the selected mode is never communicated back to
the panel. This either has to be added to the driver, or the drivers
in question have to be converted to drm_bridges (suggestion from
#freedreno). That should allow us to select a mode at runtime, and
downstream even defines "fast paths" to switch from one mode to the
next (e.g. when only adjusting the refresh rate) without powering the
panel off and on again, which we can hopefully support too.

For now the choice between either mode has been hardcoded behind a
static const bool.

- DSC

Not much to discuss here except that "it works" after piecing together
various series on the lists. No dependencies to make this series
apply/compile, though.

- pclk

The brunt of the discussion is around getting these command mode
panels functioning at their desired 60Hz or 120Hz refresh rate without
tearing/artifacts, and without hacks. Part of that discussion around
DSC-specific timing adjustments is happening in [1], but the sofef01
(non-DSC) Driver-IC is also struggling on the Xperia 5 specifically,
as outlined in that specific patch. That is currently "addressed"
with a "porch hack" but should probably have some sort of overhead /
transfer time taken into account in the MSM DSI driver.

Let me know what the best place is to collate all the relevant info
(links to downstream panel DTS, outcomes with different patches and
tweaks, etc). A new fd.o drm/msm issue?

[1]: https://gitlab.freedesktop.org/drm/msm/-/issues/24#note_1917707

Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
---
Marijn Suijten (10):
drm/panel: Clean up SOFEF00 config dependencies
dt-bindings: display: panel: Describe Sony Xperia XZ3's LGD panel
drm/panel: Add LGD panel driver for Sony Xperia XZ3
arm64: dts: qcom: sdm845-akatsuki: Configure OLED panel
dt-bindings: display: panel: Describe Samsung SOFEF01-M Display-IC
drm/panel/samsung-sofef01: Add panel driver for Sony Xperia 5 / 10 II
dt-bindings: display: panel: Describe Samsung SOFEF03-M Display-IC
drm/panel/samsung-sofef03: Add panel driver for Sony Xperia 5 II
dt-bindings: display: panel: Describe Sony Xperia 1 display
drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1

.../bindings/display/panel/samsung,sofef01-m.yaml | 109 ++++++
.../bindings/display/panel/samsung,sofef03-m.yaml | 73 ++++
.../bindings/display/panel/sony,akatsuki-lgd.yaml | 71 ++++
.../display/panel/sony,griffin-samsung.yaml | 73 ++++
.../dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts | 9 +
drivers/gpu/drm/panel/Kconfig | 52 ++-
drivers/gpu/drm/panel/Makefile | 4 +
drivers/gpu/drm/panel/panel-samsung-sofef01.c | 360 ++++++++++++++++++
drivers/gpu/drm/panel/panel-samsung-sofef03.c | 423 +++++++++++++++++++++
drivers/gpu/drm/panel/panel-sony-akatsuki-lgd.c | 362 ++++++++++++++++++
drivers/gpu/drm/panel/panel-sony-griffin-samsung.c | 410 ++++++++++++++++++++
11 files changed, 1945 insertions(+), 1 deletion(-)
---
base-commit: dbd91ef4e91c1ce3a24429f5fb3876b7a0306733
change-id: 20230521-drm-panels-sony-3c5ac3218427

Best regards,
--
Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>