Re: [PATCH 0/3] Add Intel 8254 Counter support

From: andy . shevchenko
Date: Sat May 20 2023 - 05:54:02 EST


Sun, Apr 16, 2023 at 01:36:52PM -0400, William Breathitt Gray kirjoitti:
> The Intel 8254 PIT first appeared in the early 1980s and was used
> initially in IBM PC compatibles. The popularity of the original Intel
> 825x family of chips led to many subsequent variants and clones of the
> interface in various chips and integrated circuits. Although still
> popular, interfaces compatible with the Intel 8254 PIT are nowdays
> typically found embedded in larger VLSI processing chips and FPGA
> components rather than as discrete ICs.
>
> This patch series introduces a library to provide support for interfaces
> compatible with the venerable Intel 8254 Programmable Interval Timer
> (PIT). Modules wanting access to the i8254 library should select the
> newly introduced CONFIG_I8254 Kconfig option, and import the I8254
> symbol namespace.
>
> Support for the i8254 is added in respective follow-up patches for the
> 104-dio-48e driver and stx104 driver whose devices feature i8254
> compatible interfaces. Several additional dependencies are necessary for
> the 104-dio-48e [0][1][2] and stx104 [3][4].
>
> Due to the dependency requirements, I can take the i8254 introduction
> patch through the Counter tree and provide an immutable branch that can
> be merged to the GPIO and IIO trees; the 104-dio-48e patch and stx104
> patch could then be picked up separately by the respective subsystem
> maintainers.

Good job!

What I'm wondering is that. Can x86 core and others which are using that chip
utilize (some of) the functions from the library?

> [0] https://lore.kernel.org/all/05a878d340251b781387db4b6490f288e41a651c.1680543810.git.william.gray@xxxxxxxxxx/
> [1] https://lore.kernel.org/all/20230208105542.9459-1-william.gray@xxxxxxxxxx/
> [2] https://lore.kernel.org/all/cover.1679323449.git.william.gray@xxxxxxxxxx/
> [3] https://lore.kernel.org/all/20230318185503.341914-1-william.gray@xxxxxxxxxx/
> [4] https://lore.kernel.org/all/cover.1680790580.git.william.gray@xxxxxxxxxx/

--
With Best Regards,
Andy Shevchenko