Re: [PATCH v2] drm/msm/dpu: Set DPU_DATA_HCTL_EN for in INTF_SC7180_MASK

From: Abhinav Kumar
Date: Fri May 19 2023 - 18:01:32 EST




On 5/19/2023 11:49 AM, Konrad Dybcio wrote:
DPU5 and newer targets enable this unconditionally. Move it from the
SC7280 mask to the SC7180 one.


You mean DPU 5.0.0 right?

Fixes: 7e6ee55320f0 ("drm/msm/disp/dpu1: enable DATA_HCTL_EN for sc7280 target")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
---

I have cross-checked all the chipsets affected by this and confirmed DATA_HCTL is present and those 3 registers programmed with that feature bit are valid, hence

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>