Re: [PATCH] init: Add bdev fs printk if mount_block_root failed

[Nick Desaulniers]

On Thu, May 18, 2023 at 11:34 PM Angus Chen <angus.chen@xxxxxxxxxxxxxxx> wrote:
>
>
>
> > -----Original Message-----
> > From: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> > Sent: Friday, May 19, 2023 4:36 AM
> > To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>; Angus Chen
> > <angus.chen@xxxxxxxxxxxxxxx>
> > Cc: masahiroy@xxxxxxxxxx; vbabka@xxxxxxx; peterz@xxxxxxxxxxxxx;
> > paulmck@xxxxxxxxxx; rppt@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Al Viro
> > <viro@xxxxxxxxxxxxxxxxxx>
> > Subject: Re: [PATCH] init: Add bdev fs printk if mount_block_root failed
> >
> > I wish the commit message showed an example of the panic after the
> > patch, to contrast the before vs. after.
> en ,Did a need to send a v2 or just let it go this time?

Nah, it's fine. LGTM

> The information is print:
> [    1.570841] VFS: Cannot open root device "vda" or unknown-block(253,0): error -19
> [    1.571513] Please append a correct "root=" boot option; here are the available partitions:
> [    1.572056] fd00          256000 vda
> [    1.572058]  driver: virtio_blk
> [    1.572525] List of all bdev filesystem:
> [    1.572780]  ext2
> [    1.572781]
> [    1.573027] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(253,0)
>
> Or:
> [    1.510467] VFS: Cannot open root device "vda" or unknown-block(253,0): error -19
> [    1.512033] Please append a correct "root=" boot option; here are the available partitions:
> [    1.513724] fd00          256000 vda
> [    1.513731]  driver: virtio_blk
> [    1.514280] Can't find any bdev filesystem!
> [    1.514540] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(253,0)

-- 
Thanks,
~Nick Desaulniers