Re: [PATCH] misc: fastrpc: Fix double free of 'buf' in error path

[Sukrut Bellary]

On Fri, May 19, 2023 at 07:16:14AM +0300, Dan Carpenter wrote:
> On Thu, May 18, 2023 at 07:45:22PM -0700, Sukrut Bellary wrote:
> > > > 
> > > > Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> > > > Signed-off-by: Sukrut Bellary <sukrut.bellary@xxxxxxxxx>
> > > > ---
> > >   ^^^
> > > Put testing caveats here instead, where it will be removed from the
> > > git log.
> > >
> > 
> > Shall I add "This is based on static analysis only. Compilation tested"
> > here 
> > or 
> > is it not required to mention this for all the fixes?
> > Can you please recommend what's is the preferred method I need to follow?
> 
> You can't go wrong with always adding it.  The untested part is useful
> to know.  Also it's good to know how a bug is found so we can say if
> it's affecting user and so we can improve our processes going forward.
>
Ok, that's clear. Thanks for the input.

Regards,
Sukrut Bellary

> regards,
> dan carpenter
>