RE: [PATCH net] net: fec: remove useless fec_enet_reset_skb()

[Wei Fang]

> -----Original Message-----
> From: Simon Horman <simon.horman@xxxxxxxxxxxx>
> Sent: 2023年5月19日 1:18
> To: Wei Fang <wei.fang@xxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; Frank.Li@xxxxxxxxxxxxx; Shenwei Wang
> <shenwei.wang@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net] net: fec: remove useless fec_enet_reset_skb()
> 
> On Thu, May 18, 2023 at 09:00:16PM +0800, wei.fang@xxxxxxx wrote:
> > From: Wei Fang <wei.fang@xxxxxxx>
> >
> > This patch is a cleanup for fec driver. The fec_enet_reset_skb() is
> > used to free skb buffers for tx queues and is only invoked in
> > fec_restart(). However, fec_enet_bd_init() also resets skb buffers and
> > is invoked in fec_restart() too. So fec_enet_reset_skb() is redundant
> > and useless.
> >
> > Fixes: 59d0f7465644 ("net: fec: init multi queue date structure")
> > Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> 
> Hi Wei Fang,
> 
> this change looks fine to me.
> But it feels much more like a cleanup than a fix to me:
> what user-visible problem is it fixing?
> 
There is no user-visible problem, just a cleanup.

> If so, I suggest targeting against net-next without the fixes tag.
Okay, I'll change the tree tag. Thank you!