Re: [PATCH] sched: core: Simplify cpuset_cpumask_can_shrink()

[Mukesh Ojha]

On 5/19/2023 2:04 AM, Li zeming wrote:
> Remove useless intermediate variable "ret" and its initialization.
> Directly return dl_cpuset_cpumask_can_shrink() result.
>
> Signed-off-by: Li zeming <zeming@xxxxxxxxxxxx>

Acked-by : Mukesh Ojha <quic_mojha@xxxxxxxxxxx>

-Mukesh
> ---
>   kernel/sched/core.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index a66960da3f5c..f3f2ece26291 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -9273,14 +9273,10 @@ void __init init_idle(struct task_struct *idle, int cpu)
>   int cpuset_cpumask_can_shrink(const struct cpumask *cur,
>   			      const struct cpumask *trial)
>   {
> -	int ret = 1;
> -
>   	if (cpumask_empty(cur))
> -		return ret;
> -
> -	ret = dl_cpuset_cpumask_can_shrink(cur, trial);
> +		return 1;
>   
> -	return ret;
> +	return dl_cpuset_cpumask_can_shrink(cur, trial);
>   }
>   
>   int task_can_attach(struct task_struct *p,